First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 951
Product:  
Component:  
Status: RESOLVED
Resolution: FIXED
Assigned To: Bug list <dcplusplus-bugs@lists.sourceforge.net>
Hardware:  
OS:  
Version:  
Priority:  
Severity:  
Reporter: TheParanoidOne <theparanoidone@users.sf.net>
Add CC:
CC:
URL:
Summary:

Attachment Type Created Size Actions
patch patch 2006-06-11 10:44 CEST 2.08 KB Edit | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 951 depends on: Show dependency tree
Show dependency graph
Bug 951 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments:







View Bug Activity   |   Format For Printing   |   Clone This Bug


Description:   Opened: 2006-06-11 10:42 CEST
Setting the UDP port higher than 32767 causes it to be treated as a negative
number, as shown by /connection:

*** IP: xx.xx.xx.xx, Port: 51412/-14124

This is because SearchManager.getPort() returns a signed short. This does not
happen with the TCP port as ConnectionManager.getPort() correctly returns an
unsigned short.

------- Comment #1 From TheParanoidOne 2006-06-11 10:44 CEST -------
Created an attachment (id=256) [edit]
patch

Attached patch fixes the signedness of the getPort() function, as well as a
number of other port-related variables.

------- Comment #2 From Steven Sheehy 2006-06-17 02:28 CEST -------
The patch doesn't fix the port signedness in the gui...

------- Comment #3 From TheParanoidOne 2006-06-17 04:29 CEST -------
(In reply to comment #2)
> The patch doesn't fix the port signedness in the gui...

In what sense?

------- Comment #4 From Jacek Sieka 2006-06-17 11:17 CEST -------
which part of the gui? the parts that use getPort are fixed...

------- Comment #5 From Steven Sheehy 2006-06-17 12:00 CEST -------
MainFrame.cpp: 557-558
UPnP.h: 31
UPnP.cpp: 27

Perhaps it doesn't matter if these are changed or not, but for consistency
sake, they should be changed to use unsigned short.

First Last Prev Next    No search results available      Search page      Enter new bug